OpenMW 0.45.0

Anything related to PR, release planning and any other non-technical idea how to move the project forward should be discussed here.
User avatar
psi29a
Posts: 4625
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: OpenMW 0.45.0

Post by psi29a » 12 Nov 2018, 11:45

Merged: https://github.com/OpenMW/openmw/pull/2029

Want me to back-port to 0.45? Then we have 200 issues :)

User avatar
akortunov
Posts: 613
Joined: 13 Mar 2017, 13:49
Location: Samara, Russian Federation

Re: OpenMW 0.45.0

Post by akortunov » 12 Nov 2018, 11:54

psi29a wrote:
12 Nov 2018, 11:45
Merged: https://github.com/OpenMW/openmw/pull/2029

Want me to back-port to 0.45? Then we have 200 issues :)
Since there are no RC builds for Linux and MacOS yet, I suggest to backport this fix and update Windows builds.
Also there was a request to update OpenAL-soft version in Windows builds to 1.18 to avoid bug with underwater sounds.

User avatar
akortunov
Posts: 613
Joined: 13 Mar 2017, 13:49
Location: Samara, Russian Federation

Re: OpenMW 0.45.0

Post by akortunov » 12 Nov 2018, 12:16

And what's up with Coverity Scan? Can the issue be because of excluded Recast Navigation?

User avatar
psi29a
Posts: 4625
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: OpenMW 0.45.0

Post by psi29a » 12 Nov 2018, 12:28

I'm not sure what's up there... I'm going try again now that I'm back.

Backporting now... New RCs please.

User avatar
psi29a
Posts: 4625
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: OpenMW 0.45.0

Post by psi29a » 12 Nov 2018, 16:35

coverity scan now takes forever on travis (combination of gcc8 and openmw's size).

I'm going to manually do this and upload my results. If that works, then I'll have to re-think how to trigger coverity builds.

User avatar
psi29a
Posts: 4625
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: OpenMW 0.45.0

Post by psi29a » 13 Nov 2018, 17:12

Good news and bad news.

Good news:
* Finally managed to get a full build over to Coverity, you can check it out:
https://scan.coverity.com/projects/open ... b=overview

Bad news:
* Latest changes to the coverity tool and our own code has pushed us over the build time limit of 50m. The build, of just openmw, completes at 45 minutes but it takes longer than 5 minutes to upload the result to Coverity which is why we haven't had a successful upload.

Ugly news:
* While 7 old issues were eliminated, 69 new ones have cropped up.
* 5 new issues are marked as 'high', 3 of which is related to our own code and 2 with /extern/recastnavigation itself.

8-)

User avatar
akortunov
Posts: 613
Joined: 13 Mar 2017, 13:49
Location: Samara, Russian Federation

Re: OpenMW 0.45.0

Post by akortunov » 13 Nov 2018, 17:52

psi29a wrote:
13 Nov 2018, 17:12
Ugly news:
* While 7 old issues were eliminated, 69 new ones have cropped up.
* 5 new issues are marked as 'high', 3 of which is related to our own code and 2 with /extern/recastnavigation itself.
Another good news:
1. Most of these 69 issues come from autogenerated moc files (code duplication, we just did not scan moc files earlier) and from recast navigation itself.
2. Also there are some issues with editor, since previously we scanned only game itself (probably that's why we did not hit the 50 min tilme limit).

User avatar
akortunov
Posts: 613
Joined: 13 Mar 2017, 13:49
Location: Samara, Russian Federation

Re: OpenMW 0.45.0

Post by akortunov » 13 Nov 2018, 19:05

Also I have a guess why filtering does not work:
2. *moc_*.cxx supposed to work with files with .cxx resolution, but now we get (also?) mocs with .cpp resolution.
1. Path /extern/recastnavigation/.* is absolute, but the real path is the /home/psi29a/openmw/extern/recastnavigation/.*

User avatar
psi29a
Posts: 4625
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: OpenMW 0.45.0

Post by psi29a » 13 Nov 2018, 20:26

akortunov wrote:
13 Nov 2018, 17:52
1. Most of these 69 issues come from autogenerated moc files (code duplication, we just did not scan moc files earlier) and from recast navigation itself.
I'm trying to see if we can exclude those, wondering why they got included as nothing has changed there.
akortunov wrote:
13 Nov 2018, 17:52
2. Also there are some issues with editor, since previously we scanned only game itself (probably that's why we did not hit the 50 min tilme limit).
No, that isn't true. Only openmw was being built for coverity on Travis. OpenMW itself has always been 'on the edge', but with recent additions to our code we've hit the timeout. Adding openmw-cs, launcher, importers, etc. would have pushed it up to 2 hours otherwise (only 2 CPUs).

What I uploaded was the almost everything because I was building it locally with coverity.

User avatar
Ace (SWE)
Posts: 827
Joined: 15 Aug 2011, 14:56

Re: OpenMW 0.45.0

Post by Ace (SWE) » 13 Nov 2018, 23:50

Have some new Windows RCs then, as well as with updated OpenAL-soft to 1.19.1

32-bit
64-bit

Post Reply