OpenMW 0.45.0

Anything related to PR, release planning and any other non-technical idea how to move the project forward should be discussed here.
User avatar
lysol
Posts: 1303
Joined: 26 Mar 2013, 01:48
Location: Sweden

Re: OpenMW 0.45.0

Post by lysol » 08 Feb 2019, 08:02

Great. I suspected it was probably always like this but after installing five thousand versions of OpenMW, I stopped caring about that after the first thousand.
Normal mapped texture replacers, exclusive for OpenMW:
My Nexus page

User avatar
psi29a
Posts: 4617
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: OpenMW 0.45.0

Post by psi29a » 08 Feb 2019, 08:59

1) We'll likely want to change that in the future (but not now). We should be proud of what we built under the GPL. :)

User avatar
Ace (SWE)
Posts: 827
Joined: 15 Aug 2011, 14:56

Re: OpenMW 0.45.0

Post by Ace (SWE) » 08 Feb 2019, 16:54

The problem is that the license field in the NSIS installer is only designed for showing end-user license agreements that you're required to accept to install the software, which doesn't fit with the GPL which is an open-source license.

User avatar
psi29a
Posts: 4617
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: OpenMW 0.45.0

Post by psi29a » 08 Feb 2019, 16:57

GPL has user-rights as well... the end user has a right to see the source code of this application. In the text should also be a link to where to find it.

User avatar
AnyOldName3
Posts: 1495
Joined: 26 Nov 2015, 03:25

Re: OpenMW 0.45.0

Post by AnyOldName3 » 08 Feb 2019, 17:56

Yeah, you're definitely supposed to agree to the GPL before using software covered by it. Otherwise, you might not realise that you're not allowed to give the installer to someone else without making sure they have the ability to access the source code.
AnyOldName3, Master of Shadows

User avatar
Ace (SWE)
Posts: 827
Joined: 15 Aug 2011, 14:56

Re: OpenMW 0.45.0

Post by Ace (SWE) » 08 Feb 2019, 20:20

I actually looked this up back when I started doing the NSIS packages (After a comment / complaint by a user), and while you're required to provide the GPL to the user to inform them of their rights (like how we do as a LICENSE file in the installation directory), you're at the same time expected to let the user use your software without requiring them to agree to abide by the GPL - as it has no legal requirements for them as a user of the software.

So if our installer is to show the GPL, then it can't be in a license page that requires the user to accept the GPL before they're allowed to install the software, rather it should be in a license page that simply informs the user of their provided rights under the GPL.

User avatar
AnyOldName3
Posts: 1495
Joined: 26 Nov 2015, 03:25

Re: OpenMW 0.45.0

Post by AnyOldName3 » 08 Feb 2019, 21:00

And we're not allowed to 'go with the flow' of all the other pieces of GPL software which display it and make you agree with it to proceed?
AnyOldName3, Master of Shadows

User avatar
psi29a
Posts: 4617
Joined: 29 Sep 2011, 10:13
Location: Belgium
Gitlab profile: https://gitlab.com/psi29a/
Contact:

Re: OpenMW 0.45.0

Post by psi29a » 08 Feb 2019, 21:55

Can't we modify the installer to not use the word 'agree' but just 'next' or something similar? Maybe a bit of header text: OpenMW is developed and shipped under the GPLv3 license. Here it is for your convenience and a link to the source.

User avatar
klorax
Posts: 31
Joined: 29 Apr 2018, 19:55
Contact:

Re: OpenMW 0.45.0

Post by klorax » 08 Feb 2019, 22:03

Just rename the button to "Ok" (or "Next" as @psi29a pointed out), rather than "Accept"/"Agree"? :)
The startup notice

For interactive programs, it is usually a good idea to make the program display a brief notice about copyright and copying permission when it starts up. See the end of the GNU GPL for more information about this. [1]
... To do so, attach the following notices to the program. ...

Code: Select all

    <one line to give the program's name and a brief idea of what it does.>
    Copyright (C) <year>  <name of author>

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <https://www.gnu.org/licenses/>.
[2].
Sincerely,
Klorax


:lol: 🕹 OpenMW Mods: Vanilla Birthsigns 🍦.

User avatar
Ace (SWE)
Posts: 827
Joined: 15 Aug 2011, 14:56

Re: OpenMW 0.45.0

Post by Ace (SWE) » 09 Feb 2019, 00:35

The NSIS installer is not really configurable enough to modify the setup pages themselves, we'd probably have to switch to wix to be able to do more customization in our CMakeList.
At the moment, if you want to do anything more than the default installer then it requires modifying CMake itself and writing new NSIS installer scripts, which I'd prefer to not do. (I did so earlier to remove the license page entirely, but updates keep messing that up)

Post Reply