OpenMW 0.41.0

Anything related to PR, release planning and any other non-technical idea how to move the project forward should be discussed here.
User avatar
scrawl
Posts: 2008
Joined: 18 Feb 2012, 11:51
Contact:

Re: OpenMW 0.41.0

Post by scrawl » 22 Dec 2016, 14:45

Um, I made that scan for the master branch, not 0.41 :roll: Don't worry about it.

FWIW, the atan2 one is a false positive, the others are now fixed.

Allofich
Posts: 104
Joined: 28 May 2016, 12:50

Re: OpenMW 0.41.0

Post by Allofich » 22 Dec 2016, 14:57

For the atan2 false positive, I don't understand what's happening so I might be saying something stupid, but does Coverity just think it's wrong because it sees variable names with x and y in the opposite order? Would it make sense to just store x and y as oppositely named variables and then pass them on in the order Coverity expects, maybe with an explanatory comment? Might help avoid more misunderstandings in the future.

User avatar
psi29a
Posts: 3363
Joined: 29 Sep 2011, 10:13
Github profile: https://github.com/psi29a/
Contact:

Re: OpenMW 0.41.0

Post by psi29a » 22 Dec 2016, 15:02

scrawl wrote:Um, I made that scan for the master branch, not 0.41 :roll: Don't worry about it.

FWIW, the atan2 one is a false positive, the others are now fixed.
Ah, purely coincidence that the tag was made around the time the scan was triggered. ;)

Good to know and thanks Scrawl, that is what I wanted to hear. 8-)

I'll get on the release for main PPA and Debian when I get back from posting Christmas cards...

User avatar
Jyby
Posts: 406
Joined: 10 Dec 2013, 04:16

Re: OpenMW 0.41.0

Post by Jyby » 22 Dec 2016, 15:06

scrawl wrote:FWIW, the atan2 one is a false positive
Because you've flipped the x and y vectors in the rest of the code? This looks suspicious because atan2 is a piecewise function. You might not be getting what you expect. I haven't looked into what we're doing exactly though..

Image

To those who don't know, you can take away from this function the differing behavior if you flip x and y.

atan2(1,0) = pi/2
atan2(0,1) = 0

If you think your usage is correct, it would be wise to suppress the coverty result, perhaps with local variables set to the dirx diry, and make a comment about it incase someone looks at that code again.
Macbook Air 2013 - 1.7GHz Intel i7 - 8 GB - 512 GB SSD - Intel HD 5000
Windows 10 PC - 4GHz Intel i7 - 16 GB - 512 GB SSD - EVGA GTX 1060 SSC

Chris
Posts: 1250
Joined: 04 Sep 2011, 08:33

Re: OpenMW 0.41.0

Post by Chris » 23 Dec 2016, 00:01

Jyby wrote:Because you've flipped the x and y vectors in the rest of the code? This looks suspicious because atan2 is a piecewise function.
Many applications tend to use 0 degrees as a forward-facing angle. Given that, atan2's Y parameter maps to the right-facing vector component, and the X parameter maps to the forward-facing vector component. However, most 2D and 3D applications use X as the right-facing vector component, and either Y, +Z, or -Z as the forward-facing vector component. So properly mapping that to atan2 makes the X component fit the Y parameter, and the Y/+Z/-Z component fit the X parameter.

K1ll
Posts: 128
Joined: 06 Aug 2011, 21:54

Re: OpenMW 0.41.0

Post by K1ll » 23 Dec 2016, 01:17

OpenMW 0.41.0 Linux targz package release builds:

32 Bit
64 Bit

sg1efc
Posts: 62
Joined: 16 Nov 2012, 02:35

Re: OpenMW 0.41.0

Post by sg1efc » 23 Dec 2016, 01:54

K1ll wrote:OpenMW 0.41.0 Linux targz package release builds:

32 Bit
64 Bit
Thanks everyone! 8-)

User avatar
raevol
Posts: 2349
Joined: 07 Aug 2011, 01:12
Location: Caldera

Re: OpenMW 0.41.0

Post by raevol » 24 Dec 2016, 00:42

Shoot, I think I am still waiting on the OSX release package. I am leaving in a few hours and may not be able to do the release until Monday. :| Sorry for the delay everyone.

User avatar
Atahualpa
Posts: 732
Joined: 09 Feb 2016, 20:03

Re: OpenMW 0.41.0

Post by Atahualpa » 24 Dec 2016, 00:48

No worries, raevol. A release on Monday would be really nice -- just after the Christmas celebrations when everyone is full up and satisfied. :)
The change log and the videos are ready; let's hope that there are no errors popping up.

weedfreak
Posts: 53
Joined: 29 Jan 2016, 09:44

Re: OpenMW 0.41.0

Post by weedfreak » 24 Dec 2016, 09:42

0.41 is now released on Arch! No need to wait until Monday.

Locked

Who is online

Users browsing this forum: No registered users and 2 guests