A few comments: Your results are in percent, which is not very useful, so you should replace the 100 with 1.
This is supposed to be a general purpose skill gain formulae, so anything related to alchemy needs to be generalised. I suggest replacing skill_potion_creation with skill_gain_factor and explain that this comes form the skill record.
For fSpecialSkillBonus I would use specialisation_bonus and then write in the annotations that this is either 1 or fSpecialSkillBonus, depending on if the skill matches the characters specialisation.
Anyway, looks like we got it. Good job! After you have run your additional tests, can you wikify that whole thing (on the formulae page linked elsewhere)?
specialisation_bonus = value of fSpecialSkillBonus (default: 0.80) when the Player has the same specialization as the skill or 1.00 if not.
shouldn't this be the other way round? the way that it's written, if you have the same specialization as the skill you would level that skill slower?
Edit: noticed that it's 1 / x. :facepalm:
still kind of misleading that a lower value in a "bonus" variable results in a higher bonus. but hey, it's morrowind
Lazaroth wrote:
@Mickel I can take a closer look at it when I've slept.
Some comments:
Keep alchemy levels at the same point (this requires a lot of reloading). The level has a big impact on the result. So at lower levels you're underestimating and at higher levels you are overestimating if you take a range. I'm not even sure if within a level there is a constant chance. Best is to focus on one aspect at a time and see how it influences the chance.
Note that the choice of ingredients can really put you on a wrong track, especially at lower alchemy levels. I was trying to use Saltrice and Resin at Level 5. This will not give you any successes due to the fact that the resulting potion hasn't got any effect. However, the chance is most likely not changed! Due to a bug in Morrowind you can actually hear this. A failing to generate a potion normally results in the sound effect of failing potion, however when you have a success, but the potion has no effect you still get the message of failed potion, but NO sound effect.
However, the chance is most likely not changed! Due to a bug in Morrowind you can actually hear this. A failing to generate a potion normally results in the sound effect of failing potion, however when you have a success, but the potion has no effect you still get the message of failed potion, but NO sound effect.
