OSG on steroids

[Chris]

On topic: Found out that most of the time in osg::computeLocalToWorld and osg::computeWorldToLocal (used a lot in our skinning and particle system code) is spent in dynamic_cast's.

I've read that it's generally bad to use RTTI for performance-minded games. Particularly dynamic_cast because not only does it need to look up the object's real type, it needs to compare it against all possible downcasts to see if the requested type is valid. I don't know how possible it would be to try compiling with -fno-rtti at this juncture, though.

[jvoisin]

This means that the Debian version won't get this patch, right?

[psi29a]

This means that the Debian version won't get this patch, right?

Only if we can convince them that the improvements are a good thing. However, they will likely not want to carry patches that aren't planned on going upstream, rejected by upstream or do not have anything to do with the stability of the software on Debian.

[asmo]

Maybe something that has to do with stability can be bundled w/ the other improvements … intrinsically tied of course.

[mym]

Hi scrawl,

I compiled your OSG repo (master) following your cmake options and when compiling openmw I get that:

Spoiler: Show

[ 30%] Building CXX object apps/openmw/CMakeFiles/openmw.dir/mwrender/characterpreview.cpp.o
CMakeFiles/openmw-cs.dir/view/render/object.cpp.o: In function `Quat':
/home/myo/src/osg/build/install/include/osg/Quat:66: undefined reference to `osg::Quat::makeRotate(double, osg::Vec3f const&)'
/home/myo/src/osg/build/install/include/osg/Quat:66: undefined reference to `osg::Quat::makeRotate(double, osg::Vec3f const&)'
/home/myo/src/osg/build/install/include/osg/Quat:66: undefined reference to `osg::Quat::makeRotate(double, osg::Vec3f const&)'
CMakeFiles/openmw-cs.dir/view/render/cellarrow.cpp.o: In function `Quat':
/home/myo/src/osg/build/install/include/osg/Quat:66: undefined reference to `osg::Quat::makeRotate(double, osg::Vec3f const&)'
/home/myo/src/osg/build/install/include/osg/Quat:66: undefined reference to `osg::Quat::makeRotate(double, osg::Vec3f const&)'
CMakeFiles/openmw-cs.dir/view/render/cellarrow.cpp.o:/home/myo/src/osg/build/install/include/osg/Quat:66: more undefined references to `osg::Quat::makeRotate(double, osg::Vec3f const&)' follow
collect2: error: ld returned 1 exit status
apps/opencs/CMakeFiles/openmw-cs.dir/build.make:8128: recipe for target 'openmw-cs' failed
make[2]: *** [openmw-cs] Error 1
CMakeFiles/Makefile2:669: recipe for target 'apps/opencs/CMakeFiles/openmw-cs.dir/all' failed
make[1]: *** [apps/opencs/CMakeFiles/openmw-cs.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 30%] Building CXX object apps/openmw/CMakeFiles/openmw.dir/mwworld/worldimp.cpp.o
[ 30%] Building CXX object apps/openmw/CMakeFiles/openmw.dir/engine.cpp.o
Linking CXX executable ../../openmw
../../components/libcomponents.a(attach.cpp.o): In function `Quat':
/home/myo/src/osg/build/install/include/osg/Quat:66: undefined reference to `osg::Quat::makeRotate(double, osg::Vec3f const&)'
collect2: error: ld returned 1 exit status
apps/openmw/CMakeFiles/openmw.dir/build.make:6040: recipe for target 'openmw' failed
make[2]: *** [openmw] Error 1
CMakeFiles/Makefile2:369: recipe for target 'apps/openmw/CMakeFiles/openmw.dir/all' failed
make[1]: *** [apps/openmw/CMakeFiles/openmw.dir/all] Error 2
Makefile:107: recipe for target 'all' failed
make: *** [all] Error 2

[scrawl]

Most likely some OpenMW object files didn't get recompiled although they should. Do a clean rebuild (make clean).

Or the OSG header files used don't match the used library files. Open cmake-gui to check if headers and libs were found correctly. Check OpenMW and OSG are both built in release mode. (In RelWithDebInfo and Debug modes, osg library files get a "d" or "rd" suffix which may prevent the cmake script from finding the libs if OpenMW wasn't set to the same build type).

[mym]

Oops, indeed you were right. A make clean did the thing. Thank you very much.

[scrawl]

Pushed two more osg commits, one of which has been proposed upstream. More frames \o/

I've started profiling the OpenMW game logic. Two resulting optimization commits are in master and three more as pull requests. In total with all patches applied, Balmora improved from 290 FPS to 310 FPS. I'm happy with that for an evening's work.

[raevol]

Wowow! Great job! Really happy that we are at the point where we can start optimizing, and really glad you're making some headway with it! Thanks for all of your hard work scrawl!

[sandstranger]

d