Search found 463 matches

by akortunov
12 Nov 2018, 11:54
Forum: Organisation and Planning
Topic: OpenMW 0.45.0
Replies: 199
Views: 25528

Re: OpenMW 0.45.0

Merged: https://github.com/OpenMW/openmw/pull/2029 Want me to back-port to 0.45? Then we have 200 issues :) Since there are no RC builds for Linux and MacOS yet, I suggest to backport this fix and update Windows builds. Also there was a request to update OpenAL-soft version in Windows builds to 1.1...
by akortunov
11 Nov 2018, 09:54
Forum: General
Topic: Recent Negativity Regarding OpenMW
Replies: 83
Views: 11847

Re: Recent Negativity Regarding OpenMW

Namely your own list of MWSE functions: https://wiki.openmw.org/index.php?title=MWSE Has very sensible extended getters and setters. As I said, MWSE works with references and strings ("long" variables) in a quite hackish way. From what I can tell, all these setters supposed to work with references,...
by akortunov
11 Nov 2018, 06:05
Forum: General
Topic: Recent Negativity Regarding OpenMW
Replies: 83
Views: 11847

Re: Recent Negativity Regarding OpenMW

Why isn't there already a fork for MWSE functions? Or even LUA. MWSE 1.x is a batch of hacks with extremely weird syntax and own bugs, so no one voluntereed to port and maintain it. When we tried to determine what we can use from MWSE, we figured out that only trigonometry functions are good enough...
by akortunov
10 Nov 2018, 05:11
Forum: Organisation and Planning
Topic: OpenMW 0.45.0
Replies: 199
Views: 25528

Re: OpenMW 0.45.0

ap0 wrote:
10 Nov 2018, 00:59
@akortunov it would be nice to suggest to the recastnavigation people to use coverity in their CI; since apparently coverity has some complains about it :P
They already use it.
by akortunov
09 Nov 2018, 10:29
Forum: Organisation and Planning
Topic: OpenMW 0.45.0
Replies: 199
Views: 25528

Re: OpenMW 0.45.0

A bit offtopic, but it seems we have no topic for 0.46 yet. Since we merged some quite large PRs recently (recastnavigation, weapon sheathing, changes in the FFMpeg API), I suppose we need to run a Coverity Scan again. Also probably we should exclude the extern/recastnavigation folder from Coverity ...
by akortunov
08 Nov 2018, 11:35
Forum: General Development
Topic: New compiler warnings
Replies: 5
Views: 263

Re: New compiler warnings

After some investigation I am inclined to think that "Potential leak of memory" spam is a false-positive too. CSMPrefs::Shortcut is derived from QObject, and we assign this widget to the parent QObject. During parent QObject destruction, Qt should destruct all child objects: QObjects organize themse...
by akortunov
08 Nov 2018, 11:01
Forum: Organisation and Planning
Topic: OpenMW 0.45.0
Replies: 199
Views: 25528

Re: OpenMW 0.45.0

psi29a wrote:
08 Nov 2018, 10:06
If that works, should it be cherry-picked into 0.45 so we can get our 200 issues back? :)
Definely yes.
by akortunov
08 Nov 2018, 09:49
Forum: General Development
Topic: New compiler warnings
Replies: 5
Views: 263

Re: New compiler warnings

In file included from /home/travis/build/OpenMW/openmw/apps/opencs/model/world/idcompletionmanager.cpp:1: In file included from /home/travis/build/OpenMW/openmw/apps/opencs/model/world/idcompletionmanager.hpp:5: In file included from /usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/map:61:...
by akortunov
08 Nov 2018, 09:25
Forum: General Development
Topic: New compiler warnings
Replies: 5
Views: 263

Re: New compiler warnings

A typical suspicious case: CSMPrefs::Shortcut* focusSceneShortcut = new CSMPrefs::Shortcut("scene-focus-toolbar", this); connect(focusSceneShortcut, SIGNAL(activated()), this, SIGNAL(focusSceneRequest())); return; Should the connected focusSceneShortcut object be cleaned automatically, or there is a...
by akortunov
08 Nov 2018, 08:53
Forum: Organisation and Planning
Topic: OpenMW 0.45.0
Replies: 199
Views: 25528

Re: OpenMW 0.45.0