Search found 17 matches

by CyberShadow
04 Mar 2019, 18:51
Forum: General
Topic: [PATCH] Inventory sort button
Replies: 14
Views: 1853

Re: [PATCH] Inventory sort button

Well, I just saw the "Feature additions policy" in the CONTRIBUTING document, and (especially viz. "new game UI strings") it doesn't look like such patches would be in line with the project's current goals.

https://github.com/OpenMW/openmw/blob/m ... IBUTING.md
by CyberShadow
04 Mar 2019, 16:34
Forum: General
Topic: [PATCH] Inventory sort button
Replies: 14
Views: 1853

Re: [PATCH] Inventory sort button

This kind of thing would certainly be very useful. As an official feature? I did not think of it as such. The reason that the button is in the inventory space is because it is part of the item view control. Doing it the other way would require editing the layouts of every window that item views can...
by CyberShadow
04 Mar 2019, 15:32
Forum: General
Topic: [PATCH] Inventory sort button
Replies: 14
Views: 1853

[PATCH] Inventory sort button

Hello, I made this patch for myself. Maybe someone else will find it useful it, too. Screenshot: https://dump.thecybershadow.net/2b8c008710cc17a9bf1f965d526ce814/out.gif Code: diff --git a/apps/openmw/mwgui/inventorywindow.cpp b/apps/openmw/mwgui/inventorywindow.cpp index 1877ef97d..455a67cd8 100644...
by CyberShadow
04 Mar 2019, 14:30
Forum: General Development
Topic: Grey out read dialogue topics
Replies: 29
Views: 7088

Re: Grey out read dialogue topics

Showing a tip once it's already clicked is absolutely worthless in all forms, it completely defeats the purpose of the greyed out idea... Besides, once I've clicked a topic, a quick scan of the conversation will already let me know if I've read it or not. Maybe it's just me, maybe others have bad m...
by CyberShadow
04 Mar 2019, 07:05
Forum: General Development
Topic: Grey out read dialogue topics
Replies: 29
Views: 7088

Re: Grey out read dialogue topics

It is probably possible to endlessly conjecture hypothetical arguments in favor of the pedantic form of correctness.

Would any of these make any effective difference at any point in the game?
by CyberShadow
03 Mar 2019, 21:15
Forum: General Development
Topic: Grey out read dialogue topics
Replies: 29
Views: 7088

Re: Grey out read dialogue topics

Looks cool, but A bird in the hand is worth more than two in the bush. As I understood, all dialogue topics run through the script interpreter before the game knows what text they will emit, so the engine would need to either inspect the code that's about to run, or run it speculatively (and throw ...
by CyberShadow
03 Mar 2019, 17:39
Forum: General Development
Topic: Grey out read dialogue topics
Replies: 29
Views: 7088

Re: Grey out read dialogue topics

Instead of graying out topics, how about graying out the actual responses? Seems more straight-forward. Here's a quick patch which adds [NEW!] or [seen] markers to responses (changing text color is a bit more involved): diff --git a/apps/openmw/mwbase/dialoguemanager.hpp b/apps/openmw/mwbase/dialogu...