Search found 17 matches

by CyberShadow
01 Apr 2019, 16:16
Forum: General
Topic: [PATCH] Show stolen items in inventory
Replies: 11
Views: 2393

Re: [PATCH] Show stolen items in inventory

It is not the intention of the patch posted here to change any game mechanics.

If you believe that the only way to address this topic is a change in game mechanics, respectfully, that is your opinion. I only wanted to improve the UI while preserving the original mechanics.
by CyberShadow
05 Mar 2019, 19:50
Forum: General
Topic: [PATCH] Show stolen items in inventory
Replies: 11
Views: 2393

Re: [PATCH] Show stolen items in inventory

It does not make much sense since there is no "Stolen" flag for item references. I think it makes sense insofar as previewing which items the guards would confiscate. But, I agree that, as is, such a feature would probably cause a lot of bug reports due to users being confused by the unintuitive wa...
by CyberShadow
05 Mar 2019, 19:48
Forum: General
Topic: [PATCH] Show [empty] tags on empty containers
Replies: 10
Views: 1801

Re: [PATCH] Show [empty] tags on empty containers

akortunov wrote:
05 Mar 2019, 05:12
As I said, a good idea for simple tweakable mod, which overrides tooltip creation for containers.
The way I thought of this was that people who want this in their game could just apply this patch.
by CyberShadow
05 Mar 2019, 19:45
Forum: General
Topic: [PATCH] Inventory sort button
Replies: 14
Views: 1991

Re: [PATCH] Inventory sort button

Looks good. However, I did not find any existing code for pop-up menus. Even very simple choice boxes seem to be implemented as entire dialog windows.
by CyberShadow
04 Mar 2019, 21:50
Forum: General
Topic: [PATCH] Show stolen items in inventory
Replies: 11
Views: 2393

[PATCH] Show stolen items in inventory

Makes stolen items in inventory/containers show up like owned items (before they are stolen), if highlighting owned items is enabled. It didn't make sense to me that the player character doesn't know which items they pilfered, yet the guards did. But, I don't think the original game had this either,...
by CyberShadow
04 Mar 2019, 20:26
Forum: General
Topic: [PATCH] Show [empty] tags on empty containers
Replies: 10
Views: 1801

Re: [PATCH] Show [empty] tags on empty containers

werdanith wrote:
04 Mar 2019, 20:20
assuming the fonts support it.
They do not (shows up as a question mark).
by CyberShadow
04 Mar 2019, 20:13
Forum: General
Topic: [PATCH] Show [empty] tags on empty containers
Replies: 10
Views: 1801

Re: [PATCH] Show [empty] tags on empty containers

I did not find "empty" among localized strings.
by CyberShadow
04 Mar 2019, 19:45
Forum: General
Topic: [PATCH] Show [empty] tags on empty containers
Replies: 10
Views: 1801

Re: [PATCH] Show [empty] tags on empty containers

That's interesting. How can I test against such a container? EDIT: Oh, you mean in a future implementation.

I tried to make the code conservative, and only show the [empty] tag only when all the information to know whether the container is empty or not is available.
by CyberShadow
04 Mar 2019, 19:43
Forum: General
Topic: [PATCH] Inventory sort button
Replies: 14
Views: 1991

Re: [PATCH] Inventory sort button

Thank you for the feedback. I've submitted the patch as a pull request: https://github.com/OpenMW/openmw/pull/2208
by CyberShadow
04 Mar 2019, 19:32
Forum: General
Topic: [PATCH] Show [empty] tags on empty containers
Replies: 10
Views: 1801

[PATCH] Show [empty] tags on empty containers

I remember newer Creation Engine versions had this. Screenshot: https://dump.thecybershadow.net/12fb9925f9d98532ca0311cafb30cbaa/18%3A28%3A17-upload.png Code: diff --git a/apps/openmw/mwclass/container.cpp b/apps/openmw/mwclass/container.cpp index 47dfa27b3..363bfbfce 100644 --- a/apps/openmw/mwclas...